Add support for nonlinear value coupling #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LegrandNico
changed the title
LegrandNico
force-pushed
the
nonlinear
branch
3 times, most recently
from
122b4ad
to
4cd862e
Compare
LegrandNico
changed the title
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #215 +/- ##
==========================================
- Coverage 95.10% 95.05% -0.05%
==========================================
Files 23 23
Lines 1184 1213 +29
==========================================
+ Hits 1126 1153 +27
- Misses 58 60 +2 ☔ View full report in Codecov by Sentry. |
KoraTMontemagno
force-pushed
the
nonlinear
branch
from
cede7c9
to
14f22e6
Compare
…he Edges variable, and can be specified when using the function .add_node in the Network class. Both the belief update and the prediction error steps have been changed. I have compared the behaviour of my code to Peter's one in Julia and they look similar. Next step will be figure out how to provide the function with parameters that can be retrieved by the model fitting, but I think I need Nicolas' help :)
Now it's possible to add different coupling functions to different value parents. There was an error in the previous code in PE calculation (it took the function g from the child node and not the parent node, in which is inputed). Minor edits: non_linear_funct is now coupling_funct
|
Alright, I think we can merge here, thank you for your work @KoraTMontemagno |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to update the functions using non linear equations
I don't know if I handled correctly the static arguments though...